Add additional logic to CallHierarchyCore.getCompilationUnitNode() - #3016
Merged
Conversation
- add check for class file to avoid checking for a java file name which won't find the .java extension and will return false - fixes eclipse-jdt#3015
Contributor
|
Since this regression was introduced by my PR #2881, I've prepared a regression test for this fix. The test creates a class folder with attached source, verifies the member is an Commit: arcivanov@cc39ae870f Feel free to cherry-pick or squash it into this PR. I couldn't push directly to your fork. |
datho7561
suggested changes
Jun 2, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
This fixes the problem for me.
I think it'd be helpful to add the regression test that Arcadiy suggested.
Contributor
Author
Will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
See issue.
How to test
Run jdt.ls test mentioned in issue.
Author checklist